Fix DSSendL2Block batch number #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
ToniRamirezM
approved these changes
May 3, 2024
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes DSSendL2Block batch number. It must use batchNumber field from the l2Block.batch object, as in parallel mode the f.wipBatch can be different of the batch that is being stored (f.sipBatch). Therefore, to be safe, we must use the batchNumber of the batch to which the L2Block belongs (l2Block.batch)
Reviewers
Main reviewers:
@ToniRamirezM