-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Logs) Build transactions batch #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! I added some comments inline - most of them are related to removing some intermediary spans which I don't think add much value. Basically, in my mind the deepest span path could look like so:
block_producer:try_build_batches:build_batch:new_batch
As compared to the current:
block_producer::serve:transaction_queue:run:try_build_batches:block_producer::batch_builder::build_batch:build_batch:new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! I left a couple of small comments inline. After these, we are good to merge.
let mut tx_id = tx.id().as_bytes().to_vec(); | ||
buf.append(&mut tx_id); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I would do something like:
but.extend_from_slice(&tx.id().as_bytes());
Added logs for transaction batch building flow.
Sample output: