Introduce std::utils assembly module
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
changed the title
std::utils assenbly modulestd::utils assembly module
bobbinth
approved these changes
Oct 16, 2023
stdlib/asm/utils.masm
Outdated
Comment on lines
7
to
10
| #! - is_empty_word is a boolean indicating whether INPUT_WORD is empty. | ||
| export.is_empty_word |
There was a problem hiding this comment.
nit: could we add a cycle count here. I believe this procedure takes 11 cycles.
frisitano
force-pushed
the
frisitano-std-asm-utils
branch
from
31879ff to
4e44645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces a
std::utilsassembly module whose purpose is to hold utility methods. It has initially been created with theis_empty_wordmethod. Usage of this procedure have been replaced in the std library.