Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiset checks: running product column should explicitly shift multiplicand #1223

Closed
wants to merge 29 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ae5fa76
feat: add simplified chiplet bus column builder
Al-Kindi-0 Nov 7, 2023
f7c83a8
feat: simplify build of chiplet vtable column
Al-Kindi-0 Nov 27, 2023
017f50a
feat: simplify the 3 decoder auxiliary columns
Al-Kindi-0 Dec 2, 2023
a01a9b7
feat: simplify the 3 decoder auxiliary columns
Al-Kindi-0 Dec 2, 2023
1c14d91
feat: simplify stack overflow auxiliary column build
Al-Kindi-0 Dec 5, 2023
f7b5961
chore: remove decoder aux-hints code
Al-Kindi-0 Dec 6, 2023
5bb973c
refactor: decoder auxiliary builder and uniformize the aux builder pa…
Al-Kindi-0 Dec 6, 2023
0bd9ee9
feat: simplify auxiliary trace building logic
Al-Kindi-0 Dec 7, 2023
e40f56e
feat: consolidate MainTrace and optimize column build
Al-Kindi-0 Dec 21, 2023
7b78039
feat: consolidate MainTrace and optimize column build
Al-Kindi-0 Dec 21, 2023
5919612
Trait for auxiliary column build (#1195)
Al-Kindi-0 Jan 19, 2024
9d48821
refactor: clean up aux column generator for stack overflow table (#1213)
bobbinth Jan 24, 2024
5f36479
refactor: Deref `MainTrace` type to `ColMatrix` (#1214)
iammadab Jan 29, 2024
c8b20a8
wip
iammadab Jan 30, 2024
51955d2
add multiset check for valid permutation
iammadab Jan 30, 2024
e465fcd
add failing test for multiset check (doesn't work when grand product …
iammadab Jan 30, 2024
da82f71
docs: Update docs to include random gamma
ginika-chinonso Jan 31, 2024
0ec5520
shift the multiplicand and divisor by alpha
iammadab Jan 31, 2024
26272b3
fix one test poc
iammadab Jan 31, 2024
4f81330
Merge branch 'fix-multiset' of github.com:iammadab/miden-vm into fix-…
iammadab Jan 31, 2024
1c6d62b
Revert "fix one test poc"
iammadab Jan 31, 2024
b94aa5d
shift non multiplicative identity values
iammadab Feb 1, 2024
08f6621
wip
iammadab Feb 5, 2024
8f4e2a0
fix: blockstack column builder
iammadab Feb 7, 2024
ad2700d
fix: factor out difference from bus_col_builder multiplicands
iammadab Feb 7, 2024
5846fa4
fix: factor out difference from block_hash_col_builder multiplicands
iammadab Feb 7, 2024
92474b6
fix; factor out difference from op_group_table_column_builder
iammadab Feb 12, 2024
66ce5f9
fix aux trace column builder
iammadab Feb 12, 2024
f8f589d
remove shift selector from build_aux_column
iammadab Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions air/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ harness = false
[features]
default = ["std"]
std = ["vm-core/std", "winter-air/std"]
internals = []

[dependencies]
vm-core = { package = "miden-core", path = "../core", version = "0.8", default-features = false }
winter-air = { package = "winter-air", version = "0.7", default-features = false }
winter-prover = { package = "winter-prover", version = "0.7", default-features = false }

[dev-dependencies]
criterion = "0.5"
Expand Down
1 change: 1 addition & 0 deletions air/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use winter_air::{
Air, AirContext, Assertion, AuxTraceRandElements, EvaluationFrame,
ProofOptions as WinterProofOptions, TraceInfo, TransitionConstraintDegree,
};
use winter_prover::matrix::ColMatrix;

mod constraints;
pub use constraints::stack;
Expand Down
Loading