Add CI jobs #14
Add CI jobs #14
Conversation
| env: | ||
| RUSTFLAGS: -Copt-level=3 -Cdebug-assertions -Coverflow-checks=y -Cdebuginfo=0 | ||
| RUST_LOG: 1 | ||
| CARGO_INCREMENTAL: 1 | ||
| RUST_BACKTRACE: 1 |
There was a problem hiding this comment.
I'm not super familiar with GitHub's CI, but I wonder if there's a nice way to avoid duplicating the env variables for these tasks? I know we could define env one "layer" above and it would be present for all of the tasks, but then it means these variables would be defined for tasks which do not need them. Not obvious what to do here after looking this up myself, but yeah. Fine to leave this.
There was a problem hiding this comment.
I'll have to admit I'm not an expert in setting CI jobs, I basically got inspiration from the latest plonky2 (got refactored yesterday).
| // TODO: address these lints | ||
| #![allow(unused)] | ||
| #![allow(clippy::type_complexity)] | ||
| #![allow(private_interfaces)] |
There was a problem hiding this comment.
I'm good with these for now, but yeah, I can probably clean these up in like an hour.
There was a problem hiding this comment.
Haha no rush, I can take care of them as well 🙂
I noticed we didn't have a CI running on this repo.
I added basic jobs:
cargo checkfor bothplonky_block_proof_genandproof_decodercargo testfor the workspacerustfmtandclippy(the latter required silencing some lints because ofproof_decoder, I added a TODO to address them in the future)