Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

core: Validation of new orders occurring at latest block #590

Open
fabioberger opened this issue Dec 13, 2019 · 2 comments
Open

core: Validation of new orders occurring at latest block #590

fabioberger opened this issue Dec 13, 2019 · 2 comments
Assignees

Comments

@fabioberger
Copy link
Contributor

Currently, Mesh validates incoming orders at the latest block height. Since eth_call's can take some time to complete, it is possible that Mesh has already processed higher block number before the order was inserted to the DB. This could lead to events being missed and the fillableTakerAmount stored in the DB being incorrect.

The solution is to block the processing of new block events while validating incoming orders and to validate them at the latest block processed by the Mesh node. We then add it to Mesh before unblocking the block event processing.

@fabioberger
Copy link
Contributor Author

Addressed in #566

@jalextowle
Copy link
Contributor

After #793, this became an issue again. Rather than reverting to the old solution of using a database lock, a new solution will be implemented in #863.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants