This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
orderwatch: Avoid re-adding expired orders to OrderWatcher #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en fill/cancel for them were found. This fix also makes it such that fill/cancel events still trigger for expired orders
fabioberger
force-pushed
the
fix/expirationEventFiring
branch
from
8d68ecd
to
369a6b8
Compare
albrow
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #364
This PR fixes the issue of expired orders were being re-added to OrderWatcher when fill/cancel events for that order trigger. Instead, the fill/cancel order events should still fire, but the order should not be re-added.