This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Enable verbose logging for go-flow-metrics #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might not actually need to merge or deploy this. I already got some useful results by just running this version of Mesh locally. See libp2p/go-libp2p-core#65. |
fabioberger
approved these changes
Nov 8, 2019
|
Superseded by #521 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gopkg.toml to use our fork of
go-flow-metricswhich enables verbose logging in a way that is compatible with our existing EFK stack. See the changes in our fork here: https://github.com/0xProject/go-flow-metrics/commits/verbose-logging. To be more specific, our fork logs a bunch of information whenever the reported rate is abnormally high.Hopefully this will help us understand what is going on with libp2p/go-libp2p-core#65.