This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
orderwatch,core,blockwatch: Improve Order Event subscription stability #566
Merged
fabioberger
merged 65 commits into
development
from
refactor/morePerformantOrderWatching
Dec 18, 2019
Merged
orderwatch,core,blockwatch: Improve Order Event subscription stability #566
fabioberger
merged 65 commits into
development
from
refactor/morePerformantOrderWatching
Dec 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
changed the title
Refactor/more performant order watching
orderwatch,core,blockwatch: Improve Order Event subscription performance
Nov 29, 2019
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
November 29, 2019 14:57
8f68748
to
28305bc
Compare
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
3 times, most recently
from
December 2, 2019 17:01
ea2b1df
to
11df17f
Compare
albrow
suggested changes
Dec 3, 2019
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
2 times, most recently
from
December 4, 2019 12:07
b770a83
to
e429ce3
Compare
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
December 12, 2019 00:19
05c67ad
to
1c4f24b
Compare
fabioberger
changed the base branch from
refactor/blockWatcher
to
development
December 12, 2019 16:39
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
December 12, 2019 16:43
d1c2756
to
931e05f
Compare
fabioberger
changed the title
orderwatch,core,blockwatch: Improve Order Event subscription performance
orderwatch,core,blockwatch: Improve Order Event subscription stability
Dec 13, 2019
albrow
suggested changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks pretty good. Much fewer suggestions this time and most of them are minor. I also messaged you separately about test coverage for the Cleanup
method.
fabioberger
commented
Dec 13, 2019
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
December 14, 2019 01:03
958f45b
to
123617b
Compare
albrow
suggested changes
Dec 16, 2019
Also need to address merge conflicts now that #580 is merged. |
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
December 17, 2019 04:42
1aa5e7a
to
7141dc9
Compare
…rentee unique order hashes
…turns fillable orders
… race-condition on adding orders and batch emit ADDED order events
…o get processed immediately, and others asynchronously
…hen Mesh exits and spins back up, it'll re-process blocks that weren't processed
…if a re-org happened and deal with these edge-cases
… as the old latest block
fabioberger
force-pushed
the
refactor/morePerformantOrderWatching
branch
from
December 18, 2019 00:02
7141dc9
to
391dd91
Compare
albrow
approved these changes
Dec 18, 2019
This was referenced Dec 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that Mesh's OrderWatcher is in complete lock-step about what the latest block it knows about is, and therefore also the block at which validations/re-validations are to be conducted. While these
eth_call
's are in progress, no further block events are processed, so that we don't introduce any race conditions. This eliminates several bugs:latest
block #590)Additionally, it:
ADDED
order events (orderwatch: Batch order events when orders added to Mesh #559)eth_call
request.