Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

orderwatch,core,blockwatch: Improve Order Event subscription stability #566

Merged
merged 65 commits into from
Dec 18, 2019
Merged

orderwatch,core,blockwatch: Improve Order Event subscription stability #566

merged 65 commits into from
Dec 18, 2019

Commits on Dec 17, 2019

  1. Update Gopkg.lock

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    68a8de2 View commit details
    Browse the repository at this point in the history

  2. Move encoding into a separate package

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    aaac163 View commit details
    Browse the repository at this point in the history

  3. Clarify the ordering of the headers returned from FindAllMiniHeadersS… 

    …ortedByNumber
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    7111983 View commit details
    Browse the repository at this point in the history

  4. Set all salts to current timestamp in nanoseconds in scenarios to gua… 

    …rentee unique order hashes
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    9553176 View commit details
    Browse the repository at this point in the history

  5. Refactor scenarios so that CreateSignedTestOrderWithExpirationTime re… 

    …turns fillable orders
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    87ff0e3 View commit details
    Browse the repository at this point in the history

  6. Make order re-validations async, occur at specific block numbers, fix… 

    … race-condition on adding orders and batch emit ADDED order events
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    f03df52 View commit details
    Browse the repository at this point in the history

  7. Handle returned errors

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    0bdc973 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary methods and rename others for clarity

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    9323648 View commit details
    Browse the repository at this point in the history

  9. Rename method for clarity

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    9f41578 View commit details
    Browse the repository at this point in the history

  10. Improve comment

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    61b10d9 View commit details
    Browse the repository at this point in the history

  11. Add comment for clarity

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    b65ded1 View commit details
    Browse the repository at this point in the history

  12. Ensure that we only catch up on order events for newly added order up… 

    … until the block number where the `handleBlockEvents` lock was acquired`
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    0fb20b2 View commit details
    Browse the repository at this point in the history

  13. Add CHANGELOG entries

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    330934c View commit details
    Browse the repository at this point in the history

  14. Don't stop blockWatcher in orderWatcher tests so that we fine-grained… 

    … control over when blocks are synced
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    2a438d4 View commit details
    Browse the repository at this point in the history

  15. Add test ensuring that ADDED order events are batch emitted when batc… 

    …h added to OrderWatcher
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    8823e9d View commit details
    Browse the repository at this point in the history

  16. Fix comments

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    4823833 View commit details
    Browse the repository at this point in the history

  17. Fix error string so that hash values are hex encoded and readable

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    bd1d1ff View commit details
    Browse the repository at this point in the history

  18. Add tests for whitelist functionality on handleBlockEvents method for… 

    … fills, cancels, cancelUpTo and re-validations
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    f7b352d View commit details
    Browse the repository at this point in the history

  19. Add test for backfilling order events for blocks processed while vali… 

    …dating an incoming order
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e9f7b63 View commit details
    Browse the repository at this point in the history

  20. relax the delta allowed to reduce ci failures

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    0d043b3 View commit details
    Browse the repository at this point in the history

  21. Increase max expected delay to match min expected delay

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    ebf7452 View commit details
    Browse the repository at this point in the history

  22. Use Ganache-cli image with keepAliveTimeout extended to 40sec

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    25925eb View commit details
    Browse the repository at this point in the history

  23. Set ganache-cli docker image to latest release

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    86b7ff5 View commit details
    Browse the repository at this point in the history

  24. signal that AtLeastOneBlockProcessed in SyncToLatestBlock before emit… 

    …ting block events
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    83980ed View commit details
    Browse the repository at this point in the history

  25. Increase block polling interval in integration tests so that at least… 

    … one block processed in a reasonable amount of time and that blocks are processed soon after we create an order
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    2e5e5a6 View commit details
    Browse the repository at this point in the history

  26. Add sleep after creating order to allow time for Mesh to sync to the … 

    …latest block, so that when it validates the order, it does so at a block height where the balance/allowance set by scenario took effect
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    43d7448 View commit details
    Browse the repository at this point in the history

  27. Fix docs to align with new order events subscription behavior

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    32e5e71 View commit details
    Browse the repository at this point in the history

  28. Improve comments about each OrderEventEndState

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    f53bc66 View commit details
    Browse the repository at this point in the history

  29. Rename ErrMaxSize to ErrMaxMessageSize for clarity

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    c181bdd View commit details
    Browse the repository at this point in the history

  30. Rename methods Encode and Decode for clarity

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    422edfd View commit details
    Browse the repository at this point in the history

  31. Store lastRevalidatedBlockNumber in DB as int64 since a 64 bit intege… 

    …r since with ~15sec block times we should be fine for the next 4.38*10^12 years
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    12222c1 View commit details
    Browse the repository at this point in the history

  32. Add comment explicitly stating that if order not found in DB, we proc… 

    …eed without further checks
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    c320379 View commit details
    Browse the repository at this point in the history

  33. Fix rebase conflicts

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    85387dd View commit details
    Browse the repository at this point in the history

  34. Pass context into ValidateAndStoreValidOrders so that it's RPC reques… 

    …ts get cancelled during a graceful shutdown
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    56b577a View commit details
    Browse the repository at this point in the history

  35. Simplify comments

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6f1abac View commit details
    Browse the repository at this point in the history

  36. Add comment explaining why we move valid orders to rejected results

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6d3ff05 View commit details
    Browse the repository at this point in the history

  37. Improve comment for clarity 

    Co-Authored-By: Alex Browne <stephenalexbrowne@gmail.com>
    @fabioberger @albrow
    fabioberger and albrow committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    c1c61fe View commit details
    Browse the repository at this point in the history

  38. Make mutex private

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    27a1c4a View commit details
    Browse the repository at this point in the history

  39. Implement method that waits until first block processed by BlockWatch… 

    …er, the parent context gets cancelled or 60seconds elapses
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    fd13db6 View commit details
    Browse the repository at this point in the history

  40. Break up ValidateAndStoreValidOrders into multiple smaller methods th… 

    …at could be tested independently
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    ce3f6cb View commit details
    Browse the repository at this point in the history

  41. Refactor FindLatestMiniHeader and FindMiniHeaderByBlockNumber to retu… 

    …rn an error if the miniHeader was not found to adhere to the DB interface expectations
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    41ec802 View commit details
    Browse the repository at this point in the history

  42. Add test covering edge-case where block at which order validation hap… 

    …pens gets re-orged out while ETH RPC request is ongoing
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6d2266f View commit details
    Browse the repository at this point in the history

  43. Revert breaking out of logic into separate function

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    555e4cb View commit details
    Browse the repository at this point in the history

  44. Ensure metadata entry exists since this test updates it

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    56878ce View commit details
    Browse the repository at this point in the history

  45. Revert refactors to OrderWatcher attempting to allow certain events t… 

    …o get processed immediately, and others asynchronously
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    001c4f3 View commit details
    Browse the repository at this point in the history

  46. Revert to using latest tag

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6bd54c0 View commit details
    Browse the repository at this point in the history

  47. Fix import

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    7f6f583 View commit details
    Browse the repository at this point in the history

  48. Rename function

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    8bb22c1 View commit details
    Browse the repository at this point in the history

  49. Insert blocks into DB only _once_ processed by OrderWatcher so that w… 

    …hen Mesh exits and spins back up, it'll re-process blocks that weren't processed
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    4f9b440 View commit details
    Browse the repository at this point in the history

  50. Revert doc changes

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    5c2276f View commit details
    Browse the repository at this point in the history

  51. Add comment and remove print

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    3b2867e View commit details
    Browse the repository at this point in the history

  52. Now that we block the block event processing, we don't need to check … 

    …if a re-org happened and deal with these edge-cases
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    ae8de2f View commit details
    Browse the repository at this point in the history

  53. Add bug fixes to CHANGELOG

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    0530258 View commit details
    Browse the repository at this point in the history

  54. Fix linter

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    507e532 View commit details
    Browse the repository at this point in the history

  55. Re-add newline

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    a14f268 View commit details
    Browse the repository at this point in the history

  56. Fix comments

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    41f0227 View commit details
    Browse the repository at this point in the history

  57. Fix PR link

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    d3acb32 View commit details
    Browse the repository at this point in the history

  58. Stick to Golang conventions with comment naming

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    b2c93f4 View commit details
    Browse the repository at this point in the history

  59. Remove unused array

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    a9b4f97 View commit details
    Browse the repository at this point in the history

  60. Handle the third case where a new latest block has the same timestamp… 

    … as the old latest block
    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    09296f6 View commit details
    Browse the repository at this point in the history

  61. Aggregate STOPPED_WATCHING events

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    87b2179 View commit details
    Browse the repository at this point in the history

  62. Handle case where no previousLatestBlock exists

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e3bc772 View commit details
    Browse the repository at this point in the history

  63. Add simple test of Cleanup() method

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    5d3fbc8 View commit details
    Browse the repository at this point in the history

  64. Simplify lastUpdated computation

    @fabioberger
    fabioberger committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    26cfc2f View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Add sleeps to rpc integration tests

    @fabioberger
    fabioberger committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    391dd91 View commit details
    Browse the repository at this point in the history