Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Handle null fee asset data in browser bindings #579

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Handle null fee asset data in browser bindings #579

merged 2 commits into from
Dec 12, 2019

Conversation

albrow
Copy link
Contributor

@albrow albrow commented Dec 9, 2019 •
edited
Loading

Previously, a null makerAssetFeeData or takerAssetFeeData was being encoded as an empty string, which is incorrect.

@albrow albrow added the browser label Dec 9, 2019
@albrow albrow assigned fabioberger and unassigned jalextowle Dec 9, 2019
fabioberger
fabioberger approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@fabioberger fabioberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once a changelog entry is added.

@albrow albrow merged commit e881b7d into 0xV3 Dec 12, 2019
@albrow albrow deleted the fix/null-fee-asset-data branch December 12, 2019 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabioberger fabioberger fabioberger approved these changes

Assignees

@albrow albrow

@fabioberger fabioberger

Labels
browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albrow @fabioberger @jalextowle