Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Conversation

@FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Aug 31, 2022

Usage related changes

  • Partially adapt to Starknet / cairo-lang 0.10.0:
    • Close Adapt to cairo-lang 0.10.0 #241
    • Tested with Starknet CLI account:
    • Predeployed accounts not guaranteed to work
    • Block state root not calculated
    • Transactions with version 1 not guaranteed to work
    • API changes:
      • Supported: get_nonce and simulate_transaction
      • Not yet supported: estimate_message_fee
  • Change python requirement to >=3.8, <3.10
  • Remove result from invoke response
  • Close Remove redundant is_alive endpoints #258

Development related changes

  • Address internal breaking changes which arose after updating to cairo-lang 0.10.0.
  • Suppress tests:
    • Majority of tests in test_account.py - Tests rely on interacting through Starknet CLI with OZ accounts which are not yet updated to Starknet 0.10.0
    • test/rpc/test_rpc_misc.py::test_get_state_update (created an issue for this: test_rpc_misc fails #257)
  • Apply syntax changes to cairo files.
  • Remove obsolete tests (like test_general_workflow_auth)
  • Predeploy Starknet CLI wallet and use it for testing instead of predeployed accounts:
    • In tests, replace execute with invoke
  • Refactor state update generation
  • Copy sequencer_api_utils.py from cairo-lang github
  • Modify RPC zero-padding
  • Instead of using constants.TRANSACTION_VERSION, define SUPPORTED_TX_VERSION constant (currently 0), one used in Devnet, another in tests.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC marked this pull request as ready for review September 7, 2022 12:44
@FabijanC FabijanC mentioned this pull request Sep 7, 2022
@FabijanC FabijanC merged commit 53a8dbf into master Sep 7, 2022
@FabijanC FabijanC deleted the adapt-0.10.0 branch September 7, 2022 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant is_alive endpoints Adapt to cairo-lang 0.10.0

2 participants