Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/realms improvments #8

Merged
merged 8 commits into from
Oct 20, 2024
Merged

Feat/realms improvments #8

merged 8 commits into from
Oct 20, 2024

Conversation

0xtekgrinder
Copy link
Owner

This PR is extracted from #4

It is focused on fixing the comments inside the extracted PR + a few improvements such as:

  • namespace handling
  • new width getter
  • use uint256 demo library
  • use correctly acl hasRole
  • use avl inside token registry
  • optimize gas usage overall
  • follow go function documentation convention
  • use ufmt instead of fmt
  • correctly format events
  • fix withdraw

@0xtekgrinder 0xtekgrinder merged commit 78f392d into master Oct 20, 2024
@0xtekgrinder 0xtekgrinder deleted the feat/realms-improvments branch October 20, 2024 11:51
@0xtekgrinder 0xtekgrinder mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xtekgrinder