From 8e889e7db2eb014ea510530815189535cb106220 Mon Sep 17 00:00:00 2001
From: Vincent Hardouin <vincenthardouin@icloud.com>
Date: Fri, 28 Jul 2023 16:43:40 +0200
Subject: [PATCH] feat: add merged bump pull requests in drift chart

---
 src/web.js | 85 ++++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 66 insertions(+), 19 deletions(-)

diff --git a/src/web.js b/src/web.js
index 1fa737a3..689d7d71 100644
--- a/src/web.js
+++ b/src/web.js
@@ -3,7 +3,7 @@ import DataTable from 'datatables.net-bs';
 import 'datatables.net-bs/css/dataTables.bootstrap.css'
 import { parseFile, replaceRepositoryWithSafeChar } from './utils.mjs';
 
-const PATH = process.env.REPOSITORY_URL || `https://raw.githubusercontent.com/1024pix/dependency-drift-tracker/main`;
+const PATH = process.env.REPOSITORY_URL || `https://raw.githubusercontent.com/1024pix/dependency-drift-tracker/add-merged-bump-pull-requests`;
 
 let driftChart;
 let pulseChart;
@@ -83,27 +83,22 @@ async function displayTitleAndSummary({ repository, path, line }) {
 }
 
 
-function createChart(ctx, label, data, property, baseColor) {
-  const labels = data.map((d, i) => new Date(d.date).toLocaleDateString());
+function createChart(ctx, data) {
   return new Chart(ctx, {
-    data: {
-      labels,
-      datasets: [
-        {
-          type: 'line',
-          label,
-          data: data.map(d => formatFloat(d[property])),
-          backgroundColor: `rgba(${baseColor.join()}, 0.2)`,
-          borderColor: `rgba(${baseColor.join()}, 1)`,
-          borderWidth: 1,
-        },
-      ],
-    },
+    data,
     options: {
       plugins: {
         tooltip: {
           callbacks: {
-            label: ({label, formattedValue}) => `${formattedValue} libyears`
+            label: (context) => {
+              const dataset = context.dataset;
+              const index = context.dataIndex;
+              const value = dataset.data[index];
+              const label = dataset.label || "";
+              const unit = dataset.unit || "";
+
+              return `${label}: ${value} (${unit})`;
+            },
           }
         }
       },
@@ -113,6 +108,14 @@ function createChart(ctx, label, data, property, baseColor) {
           beginAtZero: true,
           suggestedMin: 0,
         },
+        y2: {
+          position: "right",
+          beginAtZero: true,
+          suggestedMin: 0,
+          grid: {
+            drawOnChartArea: false,
+          },
+        }
       },
     },
   });
@@ -126,10 +129,54 @@ async function displayChart(line) {
   if (driftChart) driftChart.destroy();
   if (pulseChart) pulseChart.destroy();
 
-  driftChart = createChart(driftCtx, 'Dependency Drift', data, 'drift', [0, 63, 92]);
-  pulseChart = createChart(pulseCtx, 'Dependency Pulse', data, 'pulse', [155, 209, 132]);
+  driftChart = createChart(driftCtx, getDataForDriftChart(data));
+  pulseChart = createChart(pulseCtx, getDataForPulseChart(data));
 }
 
+function getDataForDriftChart(data) {
+  const baseColor = [0, 63, 92];
+  return {
+    labels: data.map((d, i) => new Date(d.date).toLocaleDateString()),
+    datasets: [
+      {
+        type: 'line',
+        label: 'Dependency Drift',
+        data: data.map(d => formatFloat(d.drift)),
+        backgroundColor: `rgba(${baseColor.join()}, 0.2)`,
+        borderColor: `rgba(${baseColor.join()}, 1)`,
+        borderWidth: 1,
+        yAxisID: 'y',
+        unit: 'libyears',
+      },
+      {
+        type: 'bar',
+        label: 'Merged Bump Pull Requests',
+        data: data.map(d => d.mergedBumpPullRequests),
+        yAxisID: 'y2',
+        unit: 'PR'
+      }
+    ],
+  }
+}
+
+function getDataForPulseChart(data) {
+  const baseColor = [155, 209, 132];
+  return {
+    labels: data.map((d, i) => new Date(d.date).toLocaleDateString()),
+    datasets: [
+      {
+        type: 'line',
+        label: 'Dependency Pulse',
+        data: data.map(d => formatFloat(d.pulse)),
+        backgroundColor: `rgba(${baseColor.join()}, 0.2)`,
+        borderColor: `rgba(${baseColor.join()}, 1)`,
+        borderWidth: 1,
+        unit: 'libyears',
+      },
+    ],
+  }
+};
+
 async function displayLastRun(line) {
   if (table) table.destroy();
   const response = await fetch(`${PATH}/data/last-run-${replaceRepositoryWithSafeChar(line)}.json`);