Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUMP] Update dependency @1024pix/pix-ui to ^48.7.0 (pix-editor) #825

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[BUMP] Update dependency @1024pix/pix-ui to ^48.7.0 (pix-editor) #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c4d0a
[BUMP] Update dependency @1024pix/pix-ui to ^48.7.0 (pix-editor)
renovate[bot] Nov 22, 2024
a065073
Fix test for requiered label
Jeremiejade Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pix-editor/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pix-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"devDependencies": {
"@1024pix/ember-testing-library": "^3.0.6",
"@1024pix/eslint-plugin": "^1.3.1",
"@1024pix/pix-ui": "^48.4.0",
"@1024pix/pix-ui": "^48.7.0",
"@1024pix/stylelint-config": "~5.0.2",
"@babel/eslint-parser": "^7.25.1",
"@babel/plugin-proposal-decorators": "^7.22.7",
Expand Down
6 changes: 3 additions & 3 deletions pix-editor/tests/acceptance/login-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module('Acceptance | Login', function(hooks) {
await visit('/');

// when
await fillByLabel('* Clé API', VALID_API_KEY);
await fillByLabel('Clé API *', VALID_API_KEY);
await clickByName('Se connecter');

// then
Expand All @@ -52,7 +52,7 @@ module('Acceptance | Login', function(hooks) {
await visit('/');

// when
await fillByLabel('* Clé API', INVALID_API_KEY);
await fillByLabel('Clé API *', INVALID_API_KEY);
await clickByName('Se connecter');

// then
Expand All @@ -65,7 +65,7 @@ module('Acceptance | Login', function(hooks) {
await visit('/statistics');

// when
await fillByLabel('* Clé API', VALID_API_KEY);
await fillByLabel('Clé API *', VALID_API_KEY);
await clickByName('Se connecter');

// then
Expand Down
4 changes: 2 additions & 2 deletions pix-editor/tests/acceptance/missions/creation-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ module('Acceptance | Missions | Creation', function(hooks) {
const screen = await visit('/missions/new');

// when
await fillByLabel('* Nom de la mission', 'Nouvelle mission de test');
await fillByLabel('Nom de la mission *', 'Nouvelle mission de test');
await triggerEvent(find('#mission-name'), 'keyup', '');

await fillByLabel('URL de l\'image de la carte', 'https://example.pix.fr/ma-image.png');
Expand All @@ -91,7 +91,7 @@ module('Acceptance | Missions | Creation', function(hooks) {
const screen = await visit('/missions/new');

// when
await fillByLabel('* Nom de la mission', 'Nouvelle mission de test');
await fillByLabel('Nom de la mission *', 'Nouvelle mission de test');
await triggerEvent(find('#mission-name'), 'keyup', '');
await clickByName('Annuler');

Expand Down
4 changes: 2 additions & 2 deletions pix-editor/tests/acceptance/missions/edit_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module('Acceptance | Missions | Edit', function(hooks) {
const screen = await visit('/missions/3/edit');

// when
await fillByLabel('* Nom de la mission', 'Nouvelle mission de test');
await fillByLabel('Nom de la mission *', 'Nouvelle mission de test');
await triggerEvent(find('#mission-name'), 'keyup', '');

await fillByLabel('URL de l\'image de la carte', 'https://images.pix.fr/badges/Pix_Plus-Donnee-Visualisation_des_donnees.svg.svg');
Expand Down Expand Up @@ -101,7 +101,7 @@ module('Acceptance | Missions | Edit', function(hooks) {
const screen = await visit('/missions/3/edit');

// when
await fillByLabel('* Nom de la mission', 'will trigger error');
await fillByLabel('Nom de la mission *', 'will trigger error');
await triggerEvent(find('#mission-name'), 'keyup', '');

await clickByText('Compétence');
Expand Down
4 changes: 2 additions & 2 deletions pix-editor/tests/acceptance/static-courses/creation-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ module('Acceptance | Static Courses | Creation', function(hooks) {
await clickByName('Créer un nouveau test');

// when
await fillByLabel('* Nom du test statique', 'Mon nouveau test statique');
await fillByLabel('Nom du test statique *', 'Mon nouveau test statique');
await fillByLabel('Description à usage interne', 'Une super description pour mon nouveau test');
await fillByLabel('Tags', 'cou');
await clickByText('COUrage');
Expand Down Expand Up @@ -118,7 +118,7 @@ module('Acceptance | Static Courses | Creation', function(hooks) {
await clickByName('Créer un nouveau test');

// when
await fillByLabel('* Nom du test statique', 'Mon nouveau test statique');
await fillByLabel('Nom du test statique *', 'Mon nouveau test statique');
await fillByLabel('Description à usage interne', 'Une super description');
await fillByLabel('IDs des épreuves', 'chalA\nchalC');
await clickByName('Annuler');
Expand Down
4 changes: 2 additions & 2 deletions pix-editor/tests/integration/components/form/missions-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module('Integration | Component | mission', function(hooks) {
@submitButtonText={{this.submitButtonText}}
/>`);

await fillByLabel('* Nom de la mission', 'Nouvelle mission de test');
await fillByLabel('Nom de la mission *', 'Nouvelle mission de test');
await triggerEvent(find('#mission-name'), 'keyup', '');

await fillByLabel('URL de l\'image de la carte', 'https://images.pix.fr/badges/Pix_Plus-Donnee-Visualisation_des_donnees.svg.svg');
Expand All @@ -45,7 +45,7 @@ module('Integration | Component | mission', function(hooks) {
@submitButtonText={{this.submitButtonText}}
/>`);

await fillByLabel('* Nom de la mission', 'Nouvelle mission de test');
await fillByLabel('Nom de la mission *', 'Nouvelle mission de test');
await triggerEvent(find('#mission-name'), 'keyup', '');

const button = screen.getByRole('button', { name: 'Créer la mission' });
Expand Down
4 changes: 2 additions & 2 deletions pix-editor/tests/integration/components/form/whitelisted-url-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ module('Integration | Component | Form | whitelisted-url', function(hooks) {
const urlErrorMandatoryField = screen.getByText('L\'URL est obligatoire');
assert.dom(urlErrorMandatoryField).isVisible();

await fillByLabel('* URL à whitelister', 'chouchou beignets');
await fillByLabel('URL à whitelister *', 'chouchou beignets');
const urlErrorInvalidUrl = screen.getByText('L\'URL n\'est pas valide');
assert.dom(urlErrorInvalidUrl).isVisible();

await fillByLabel('* URL à whitelister', 'https://example.org');
await fillByLabel('URL à whitelister *', 'https://example.org');
assert.dom(urlErrorInvalidUrl).isNotVisible();
assert.dom(urlErrorMandatoryField).isNotVisible();

Expand Down