Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting stylelint rules prevent usage of currentcolor #315

Closed
1 task done
derweili opened this issue Aug 2, 2023 · 1 comment · Fixed by #314
Closed
1 task done

Conflicting stylelint rules prevent usage of currentcolor #315

derweili opened this issue Aug 2, 2023 · 1 comment · Fixed by #314

Comments

@derweili
Copy link
Member

derweili commented Aug 2, 2023

Describe the bug

We currently have two conflicting stylelint rules that prevent usage of currentcolor/currentColor:

Example 1

color: currentColor;

Results in this error: Expected "currentColor" to be "currentcolor" (value-keyword-case)

Example 2

color: currentcolor;

Error: Expected variable, function or keyword for "currentcolor" of "color" (scale-unlimited/declaration-strict-value)
This is because scale-unlimited/declaration-strict-value only allows currentColor, see here.

To fix this, we should change currentColor to currentcolor in the stylelint-config:

{ ignoreValues: ['currentColor', 'inherit', 'initial', 'transparent', 'unset'] },

Steps to Reproduce

  1. use the example from above
  2. run stylelint

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Antonio-Laguna
Copy link
Member

This is fixed by #298

@Antonio-Laguna Antonio-Laguna linked a pull request Aug 2, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants