Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1520 find related improvements #1653

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

ayebare
Copy link

@ayebare ayebare commented Feb 5, 2020

Description of the Change

I have separated the find_related function into two. "get_related_query" which returns the query of get related posts, and "find_related" which uses "get_related_query",
No new logic was added.

Closes #1520

Benefits

Provide a function that returns WP_Query instance of related posts. This was requested from here #1520

Possible Drawbacks

None

Verification Process

wrote PHP unit tests for the new helper function and ran it

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • [x ] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [ x] I have added tests to cover my change.
  • All new and existing tests passed. [Some existing tests were failing before. All new tests pass.]

Applicable Issues

Changelog Entry

@ayebare ayebare requested a review from tlovett1 February 5, 2020 14:46
@felipeelia felipeelia self-assigned this Mar 15, 2022
@felipeelia felipeelia added this to the 4.1.0 milestone Mar 15, 2022
@felipeelia felipeelia merged commit 3e1da11 into develop Mar 25, 2022
@felipeelia felipeelia deleted the feature/1520-find-related-improvements branch March 25, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return instance of WP_Query instead of post array in find_related()
2 participants