-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filterable method for getting the individual term HTML to the Facet widget. #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
changed the title
Add filterable method for getting the individual term HTML
Add filterable method for getting the individual term HTML to the Facet widget.
Sep 23, 2021
Rahmon
reviewed
Sep 23, 2021
Rahmon
reviewed
Sep 23, 2021
*/ | ||
$label = apply_filters( 'ep_facet_widget_term_label', $term->name, $term, $selected ); | ||
|
||
$link = sprintf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it's worth adding a filter to $link
... 🤔
felipeelia
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Moves the markup for individual facet terms in the Facet widget into its own method, and adds a
ep_facet_widget_term_html
filter to the output to support filtering the HTML of individual facet terms.Benefits
Allows filtering the HTML of individual facet terms without needing to filter the entire output of the widget.
Possible Drawbacks
None that I'm aware of, apart from the usual considerations when introducing filters.
Verification Process
ep_facet_widget_term_html
filter to change the HTML of individual terms and confirm that changes are reflected on the front end.Checklist:
Applicable Issues
Addresses #2358.
Changelog Entry
Adds
ep_facet_widget_term_html
filter to the Facet widget for filtering the HTML of individual facet terms.