Fix usage of requiresReindex #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahmon
reviewed
Dec 20, 2021
| @@ -605,7 +606,7 @@ $features.on('change', '.js-toggle-feature', function (event) { | |||
| const { value } = event.target; | |||
| const { requiresReindex, wasActive } = event.currentTarget.dataset; | |||
|
|
|||
| if (requiresReindex && wasActive === '0' && value === '1') { | |||
| if (requiresReindex === '1' && wasActive === '0' && value === '1') { | |||
| container.style.display = 'block'; | |||
| } else { | |||
| container.style.display = null; | |||
There was a problem hiding this comment.
@felipeelia we need to check if there is an element on container because we are retrieving only if it has .requirements-status-notice--reindex and it is causing an error when we try to access container.style.display:
Cannot read properties of null (reading 'style')
Maybe we can add an early return:
if (!container) return;
Rahmon
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In #2491 we've introduced a new confirmation prompt on features activation. This PR adjusts its implementation so the prompt only appears in features that really require a reindex.
Changelog Entry
Append to the
Enabling features that require a reindex will now ask for confirmationline