-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove confusion in docs #22
Conversation
fixes issue 268 in 11ty/eleventy
Hey. Hm, I’m not too happy with either the current version or your proposed version. First of all, the includes directory is not meant for data in general. That purpose is served by data files which are a different concept. What do you think about the following? - Controls the directory inside which the template includes/extends/partials/etc can be found.
+ Controls the directory inside which the templates, extends, partials or other includes can be found. (For reference, the discussion around this started in 11ty/eleventy#268.) |
docs/config.md
Outdated
@@ -108,7 +108,7 @@ module.exports = { | |||
|
|||
### Directory for Includes | |||
|
|||
Controls the directory inside which the template includes/extends/partials/etc can be found. | |||
Controls which directory is the _includes_ directory. The _includes_ directory is meant for templates and data in general, like layout templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it is meant for 'data in general'. Is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not.
What I meant was template data in general. I wrote it in a hurry.
I think we can get rid of this line, seems redundant?
I like what you’re going for here, I wonder if it would be better like this?
|
@zachleat ,We can certainly get rid of that line. Removing 'templates' form that line can still cause confusion as layout templates are stored in the includes directory too. |
How are you defining a template? To me a template is any string using template syntax—it could be content, an include, macro, partial, layout, anything. To say something is a template doesn’t really give any extra context about what that thing is? |
See also #24 |
What about this -
|
Yes I like that a lot @coolshaurya! |
Done - changes committed |
Shipped! Thanks for iterating on this! |
fixes issue 268 in 11ty/eleventy