Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing build time cache with serverless #28

Closed
ryangittings opened this issue Mar 10, 2023 · 5 comments
Closed

Reusing build time cache with serverless #28

ryangittings opened this issue Mar 10, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ryangittings
Copy link

I’m following the docs here:

https://www.11ty.dev/docs/plugins/serverless/#re-use-build-time-cache-from-the-fetch-plugin

So, here's a test case to describe my issue. Here are two URLs:

/build/
/serverless/

Hit the serverless endpoint, and with every hit you'll see the log that it's fetching:

[11ty/eleventy-fetch] Fetching: https://dummyjson.com/products/1

https://github.com/ryangittings/11ty-serverless-fetch-issue

I’d expect the build cache to be reused and the URL not to be hit.

@zachleat zachleat self-assigned this Mar 17, 2023
@zachleat zachleat added the bug Something isn't working label Mar 17, 2023
@zachleat zachleat added this to the Eleventy Fetch v4.0.0 milestone Mar 17, 2023
@zachleat
Copy link
Member

Huh. Well, this is definitely a bug!

Using dryRun actually prevented both file reads and writes, when clearly we want to allow reads.

This will ship with Eleventy Fetch 4.0.0

@ryangittings
Copy link
Author

Awesomesauce! Can I use a patch or a specific branch in npm in the meantime?

@zachleat
Copy link
Member

This will ship in the next hour or two just going through the rest of the backlog on this repo first

@zachleat
Copy link
Member

(it’s on github now)

@zachleat
Copy link
Member

4.0 has shipped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants