You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Digging more into the issue it looks like on 0.12.1 the addTransform ran after plugins and now it runs before plugins. I'm not 100% sure if this is intended and couldn't find it documented but IMHO it's a bit of a controversial change given that the transform is used to minify the HTML and plugins occur after that, hindering the full effect of the transform.
For what is worth I have plugins enqueued first and the transform is enqueued last so I assume (maybe wrongly) that something has changed.
I'm happy to dig more into this but wanted to report this first to spark some discussion. Note that the issue I'm pointing is actually on the plugin side but has surfaced with this change which I find a bit controversial.
Environment:
OS and Version: macOS 11.6
Eleventy Version: 1.0.0-beta.2
The text was updated successfully, but these errors were encountered:
This is an automated message to let you know that a helpful response was posted to your issue and for the health of the repository issue tracker the issue will be closed. This is to help alleviate issues hanging open waiting for a response from the original poster.
If the response works to solve your problem—great! But if you’re still having problems, do not let the issue’s closing deter you if you have additional questions! Post another comment and we will reopen the issue. Thanks!
Describe the bug
I've realised that Eleventy 1.0.0 seems to have changed the order of execution between transforms and plugins. I eagerly tried to adopt 1.0.0 and saw that Eleventy Plugin Embed Twitter somehow break my site. Reported gfscott/eleventy-plugin-embed-twitter#33
Digging more into the issue it looks like on 0.12.1 the
addTransform
ran after plugins and now it runs before plugins. I'm not 100% sure if this is intended and couldn't find it documented but IMHO it's a bit of a controversial change given that the transform is used to minify the HTML and plugins occur after that, hindering the full effect of the transform.For what is worth I have plugins enqueued first and the transform is enqueued last so I assume (maybe wrongly) that something has changed.
I'm happy to dig more into this but wanted to report this first to spark some discussion. Note that the issue I'm pointing is actually on the plugin side but has surfaced with this change which I find a bit controversial.
Environment:
The text was updated successfully, but these errors were encountered: