From ee5970ca830eb39e4f06b3eca5524aee41497f21 Mon Sep 17 00:00:00 2001 From: Ricky de Laveaga Date: Mon, 5 Aug 2024 12:19:18 -0700 Subject: [PATCH 1/4] Update accessible-emoji with enhancements from WebC bed https://github.com/rdela/webcbed/pulls?q=is%3Apr --- _components/accessible-emoji.webc | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/_components/accessible-emoji.webc b/_components/accessible-emoji.webc index d1a7c8d..25773b0 100644 --- a/_components/accessible-emoji.webc +++ b/_components/accessible-emoji.webc @@ -1,8 +1,22 @@ \ No newline at end of file From e1266ea66b069282db3073e4a78d182bb7ad7c2e Mon Sep 17 00:00:00 2001 From: Ricky de Laveaga Date: Mon, 5 Aug 2024 13:31:52 -0700 Subject: [PATCH 2/4] newer emoji may not be in emoji-essential, so we need to be extra defensive https://github.com/11ty/tugboat/pull/9#issuecomment-2269834763 --- _components/accessible-emoji.webc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/_components/accessible-emoji.webc b/_components/accessible-emoji.webc index 25773b0..11800a3 100644 --- a/_components/accessible-emoji.webc +++ b/_components/accessible-emoji.webc @@ -10,13 +10,21 @@ * `⊛ ` into names, so filtering here. * https://github.com/WebReflection/emoji-essential/issues/1 * + * Newer emoji may not be in emoji-essential, so we need to be extra defensive + * * Learn more: * - https://kittygiraudel.com/2021/01/02/accessible-emojis-with-11ty/ * - https://tink.uk/accessible-emoji/ * - https://adrianroselli.com/2016/12/accessible-emoji-tweaked.html */ let label = ""; -alt ? label = alt.toString() - : label = emojiShortName(emoji).toString().replace("⊛ ", ""); +if (alt && typeof alt === 'string') { + label = alt; +} else if (typeof emoji === 'string' && typeof alt === 'undefined') { + shortName = emojiShortName(emoji); + if (typeof shortName !== "undefined") { + label = shortName.replace("⊛ ", ""); + } +} `${emoji}` \ No newline at end of file From cd4183725d3c78f9afb3d0ed63c6303b5abb81ff Mon Sep 17 00:00:00 2001 From: Ricky de Laveaga Date: Mon, 5 Aug 2024 13:52:21 -0700 Subject: [PATCH 3/4] Add comment + accessible-emoji alt usage example in index --- index.webc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/index.webc b/index.webc index 0693a6a..4137143 100644 --- a/index.webc +++ b/index.webc @@ -1,8 +1,9 @@ ----node +---js let layout = "layouts/base.webc"; // Hi --- -

Welcome to Tugboat

+ +

Welcome to Tugboat

From a3e052b225ba131dfda0f74da5ed059add822fa3 Mon Sep 17 00:00:00 2001 From: Ricky de Laveaga Date: Mon, 5 Aug 2024 13:54:28 -0700 Subject: [PATCH 4/4] js back to node frontmatter for deploy, see #6 --- index.webc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.webc b/index.webc index 4137143..e689306 100644 --- a/index.webc +++ b/index.webc @@ -1,4 +1,4 @@ ----js +---node let layout = "layouts/base.webc"; // Hi ---