Update to Ruby 3.0 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpep
approved these changes
Aug 25, 2023
| spec.add_dependency "activesupport", ">= 5.1" | ||
| spec.add_dependency "activerecord", ">= 5.1" | ||
| spec.add_dependency "activesupport", ">= 6.0", "< 7.0" | ||
| spec.add_dependency "activerecord", ">= 6.0", "< 7.0" |
| module ActiveRecord | ||
| module ConnectionAdapters | ||
| module MySQL | ||
| RSpec.describe ColumnMethods do |
There was a problem hiding this comment.
It's not weird. It's more robust than RSpec.describe ActiveRecord::ConnectionAdapters::MySQL::ColumnMethods against the possibility that the autoloader doesn't like something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration part of this was failing in Ruby 3.0 because of the keyword change in the enums.
Dropping support for Rails 5.1 and 5.2, which aren't compatible with Ruby 3.0.
Note that Rails 7 is also not supported because of a change in the Rails 7 active record internals, we'll catch that in another PR