From 30a0f81c19d5ada2186f34961110761b3352c2ca Mon Sep 17 00:00:00 2001 From: Anton Bukov Date: Fri, 23 Feb 2024 14:59:22 +0100 Subject: [PATCH 1/2] Simplify loop condition --- contracts/extensions/BaseExtension.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/extensions/BaseExtension.sol b/contracts/extensions/BaseExtension.sol index 599b229..469c0f8 100644 --- a/contracts/extensions/BaseExtension.sol +++ b/contracts/extensions/BaseExtension.sol @@ -131,7 +131,7 @@ contract BaseExtension is IPreInteraction, IPostInteraction, IAmountGetter { uint256 currentPointTime = auctionStartTime; uint256 currentRateBump = initialRateBump; - for (uint256 i = 0; i < pointsSize; i++) { + while (auctionDetails.length > 0) { uint256 nextRateBump = uint24(bytes3(auctionDetails[:3])); uint256 nextPointTime = currentPointTime + uint16(bytes2(auctionDetails[3:5])); if (block.timestamp <= nextPointTime) { From 5934eb6d8688883bff2fa85c662a7b85279dcfe9 Mon Sep 17 00:00:00 2001 From: Mikhail Melnik Date: Fri, 23 Feb 2024 21:39:23 +0400 Subject: [PATCH 2/2] linter --- contracts/extensions/BaseExtension.sol | 1 - 1 file changed, 1 deletion(-) diff --git a/contracts/extensions/BaseExtension.sol b/contracts/extensions/BaseExtension.sol index 469c0f8..baed22d 100644 --- a/contracts/extensions/BaseExtension.sol +++ b/contracts/extensions/BaseExtension.sol @@ -127,7 +127,6 @@ contract BaseExtension is IPreInteraction, IPostInteraction, IAmountGetter { } auctionDetails = auctionDetails[10:]; - uint256 pointsSize = auctionDetails.length / 5; uint256 currentPointTime = auctionStartTime; uint256 currentRateBump = initialRateBump;