Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OHW login.html to some text in Spanish #20

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

emiliom
Copy link

@emiliom emiliom commented Feb 12, 2023

Add initial customizations in Spanish for OHW Feb 27 - Mar 3, 2023, event. Include warning in English for previous users. See 2i2c-org/infrastructure#2108

This is my first attempt at customizing the login page, so I'm threading lightly. @abkfenris, see what you think about the edits! My intent is to revise further over the next week or so.

Add initial customizations in Spanish for OHW Feb 27 - Mar 3, 2023, event. Include warning in English for previous users.
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright technically!

@emiliom its not clear to me if you want this merged to see the result in practice, and iterate like that influencing oceanhackweek.2i2c.cloud directly, or if you want to iterate by review from @abkfenris in this non-merged state where you only see the HTML code.

Ping @2i2c-org/engineering requesting it to be merged and I'll or someone else will merge it.

Copy link

@abkfenris abkfenris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, though I'd love to have an English overview of the event that we could link folks too, along with instructions on how to change the JupyterLab language.


Maybe it's premature optimization, but we could setup the page with:

  • Logo
  • Current/next event alert (or contextual panel since it appears to be Bootstrap 3 CSS being loaded)
  • Login
  • Multi-lingual welcome
  • Multi-lingual instructions/links to localize interface (since we also have a notable Brazilian contingent)

Comment on lines 75 to 76
(<strong>The interface will be in Spanish by default through March 3, 2023! If you are not
participating in the OHW-español event Feb. 27 - Mar. 3, please use this hub lightly.</strong>)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a link to directions on how to switch language? We could include them as a subheading on https://oceanhackweek.org/resources/prep/jupyterhub.html or more generically send folks to https://jupyterlab.readthedocs.io/en/stable/user/language.html for now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, though I'd love to have an English overview of the event that we could link folks too, along with instructions on how to change the JupyterLab language.

We don't have the web site for the event ready to go yet. I'll work on an initial version over the next couple of days, and we can include a short-paragraph description in English.

Logo

I do plan to submit a changed logo that incorporates the modified OHW logo we've been using.

Multi-lingual instructions/links to localize interface (since we also have a notable Brazilian contingent)

I think I'm now pedalling back from changing the language default, and instead stick with the English default plus instructions for switching the language. We already have the instructions in Spanish for switching the language to Spanish. Anyways, the details are off topic here, but I'll tweak the relevant text in this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abkfenris How does my new text look?

Once you and I come to agreement about these initial changes to the login page, I'll request that the PR be merged, per @consideRatio's instructions.

@emiliom
Copy link
Author

emiliom commented Feb 13, 2023

Thanks @consideRatio and @abkfenris . Yeah, I wasn't clear. On the one hand, I think I do want to have the reassurance that this sort of simple content changes to the login page will work! Hence my emphasis on "initial" incremental updates, and yes, wanting this PR as-is or with small changes merged, before submitting possibly just one more set of content changes.

@abkfenris how does that incremental strategy sound? ie, first this modest PR possibly with tweaks, then a more substantial PR with the sort of content you've laid out above?

templates/login.html Outdated Show resolved Hide resolved
@abkfenris
Copy link

@emiliom I think the suggested text and an incremental strategy to work to work on the page works.

@emiliom
Copy link
Author

emiliom commented Feb 13, 2023

Thanks @abkfenris .

@consideRatio @2i2c-org/engineering this PR is ready to be merged.

@consideRatio consideRatio merged commit b009e87 into 2i2c-org:2i2c-ohw Feb 13, 2023
@consideRatio
Copy link
Member

consideRatio commented Feb 13, 2023

@emiliom nice! It should be reflected in up to 15 minutes (up to 10 minutes for github pages cache, 5 minutes for a refresh by jupyterhub)

@emiliom
Copy link
Author

emiliom commented Feb 13, 2023

Thanks @consideRatio ! It's a relief to have gone through one cycle of these updates. Seeing the results is already helpful for planning the next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants