Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost Explorer API (8/n): allow aws-ce-grafana-backend software to be traitlets configurable (in a "chart passthrough" manner) #4788

Closed
Tracked by #4453
consideRatio opened this issue Sep 11, 2024 · 2 comments · Fixed by #4846
Assignees

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Sep 11, 2024

Its not clearly decided what should be configured and how, but we need a system to provide configuration for the software.

An example of something that needs to be configurable is the clustername (the AWS resource naming, so openscapeshub and not openscapes for example).

Definition of done

  • Establish a traitlets based system that allows chart config -> software config in a way that doesn't make the chart understand what software config can be used.
    Z2JH does this via jupyterhub.hub.config for example.
  • Setup the software to work with traitlets based config, trial with cluster_name
  • Setup and verify passthrough chart config of cluster_name works
@consideRatio consideRatio changed the title Cost Explorer API (8/n): allow aws-ce-grafana-backend software to be configurable in a "chart passthrough" manner Cost Explorer API (8/n): allow aws-ce-grafana-backend software to be traitlets configurable in a "chart passthrough" manner Sep 11, 2024
@consideRatio consideRatio changed the title Cost Explorer API (8/n): allow aws-ce-grafana-backend software to be traitlets configurable in a "chart passthrough" manner Cost Explorer API (8/n): allow aws-ce-grafana-backend software to be traitlets configurable (in a "chart passthrough" manner) Sep 11, 2024
@consideRatio
Copy link
Contributor Author

I'm dropping this and going for hardcoded things as setting up a traitlets based system to configure the application was something I struggled with.

@consideRatio consideRatio closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@consideRatio
Copy link
Contributor Author

I've ended up settling for introducing a chart configurable environment variable for the cluster name, and will not try to make anything else configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant