Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script that can add all clusters as datasources for central grafana #1215

Merged
merged 16 commits into from
Apr 20, 2022

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Apr 18, 2022

This adds a script that updates the datasources of our central grafana (the 2i2c one) to encompass all authenticated prometheus instances of our clusters. It also adds more colors to the print_color function.

It can be ran every time we add a new cluster, or deploy the support chart for an existing one.

Note:

  1. I've ran this successfully
  2. The clusters that failed to be added for reasons that were expected were:

datasource-updater-output

Ref: #328

@GeorgianaElena GeorgianaElena requested a review from a team April 18, 2022 18:12
Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style nits, but otherwise yay!

We should run this every time we create a new cluster, so let's add that to the docs? When else should this be run?

Thank you for working on this!

deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
@GeorgianaElena GeorgianaElena added Enhancement An improvement to something or creating something new. 🏷️ monitoring labels Apr 19, 2022
@GeorgianaElena
Copy link
Member Author

GeorgianaElena commented Apr 19, 2022

Thanks for the feedback @yuvipanda 🚀 ! I believe I have addressed all the comments in the last few commits. Let me know what you think 👀

@GeorgianaElena GeorgianaElena changed the title Add all clusters as datasources for central grafana Add a script that can add all clusters as datasources for central grafana Apr 19, 2022
Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, feel free to merge after that.

Thanks a lot @GeorgianaElena!

deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick documentation notes on this, thanks so much @GeorgianaElena this looks really nice :-) I am excited to start using this central Grafana!!!

deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
deployer/update_grafana_datasources.py Outdated Show resolved Hide resolved
docs/howto/operate/grafana.md Outdated Show resolved Hide resolved
@GeorgianaElena
Copy link
Member Author

Thanks everyone for the feedback ✨ I believe I have addressed all the comments and this is now ready to merge 🚀

@GeorgianaElena GeorgianaElena merged commit 3c16800 into 2i2c-org:master Apr 20, 2022
@GeorgianaElena GeorgianaElena deleted the grafana-datasources branch April 20, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An improvement to something or creating something new.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants