-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script that can add all clusters as datasources for central grafana #1215
Add a script that can add all clusters as datasources for central grafana #1215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style nits, but otherwise yay!
We should run this every time we create a new cluster, so let's add that to the docs? When else should this be run?
Thank you for working on this!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Thanks for the feedback @yuvipanda 🚀 ! I believe I have addressed all the comments in the last few commits. Let me know what you think 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, feel free to merge after that.
Thanks a lot @GeorgianaElena!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few quick documentation notes on this, thanks so much @GeorgianaElena this looks really nice :-) I am excited to start using this central Grafana!!!
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Thanks everyone for the feedback ✨ I believe I have addressed all the comments and this is now ready to merge 🚀 |
This adds a script that updates the datasources of our central grafana (the 2i2c one) to encompass all authenticated prometheus instances of our clusters. It also adds more colors to the
print_color
function.It can be ran every time we add a new cluster, or deploy the support chart for an existing one.
Note:
Ref: #328