prometheus-node-exporter: declare cpu/mem requests and limits #2450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the node-exporter pod be evicted because it has no resource requests/limits when what needs to be evicted are other pods to resolve the situation. Let's not allow that to happen!
CPU (leap, 30 last days)
Note that the use dropped at some point. That was me upgrading the GKE based k8s cluster in #2337.
Memory (leap, 30 last days)
Why I choose the requests and limits