Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Azure terraform #2624

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Cleanup Azure terraform #2624

merged 1 commit into from
Jun 7, 2023

Conversation

yuvipanda
Copy link
Member

  • Mark optional parts of node / dask node definition as optional, so utoronto.tfvars will actually apply
  • Parameterize core node size, and specify it explicitly.
  • Remove default for k8s version, specify it explicitly. This matches the current k8s version
  • Parameterize storage size, and match it to current reality. Note that this can't be applied via tf quite yet, due to AzureFile NFS network settings may block terraform access once applied #890.

Ref #2594

@yuvipanda
Cleanup Azure terraform
5f848d4 
- Mark optional parts of node / dask node definition as optional,
  so utoronto.tfvars will actually apply
- Parameterize core node size, and specify it explicitly.
- Remove default for k8s version, specify it explicitly. This
  matches the current k8s version
- Parameterize storage size, and match it to current reality.
  Note that this can't be applied via tf quite yet, due
  to 2i2c-org#890.

Ref 2i2c-org#2594
@yuvipanda yuvipanda requested a review from a team as a code owner June 7, 2023 17:50
@yuvipanda
Copy link
Member Author

Applied with terraform apply -var-file=projects/utoronto.tfvars -refresh-only -target=azurerm_kubernetes_cluster.jupyterhub -target=azurerm_kubernetes_cluster_node_pool.user_pool

pnasrat
pnasrat approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@pnasrat pnasrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvipanda yuvipanda merged commit f9821be into 2i2c-org:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnasrat pnasrat pnasrat approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @pnasrat