Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow singleuser pods to talk to ingress controller #782

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Allow singleuser pods to talk to ingress controller #782

merged 1 commit into from
Oct 27, 2021

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Oct 27, 2021 •
edited
Loading

This allows code in hubs to talk to the ingress provider, and hence talk
to the hub via it's public URL

Thanks to @yuvipanda for spotting this and their code from here:
yuvipanda/datahub@e8544b0#diff-c7ff155658f0273e3fd2df49dee1551363b934660d0cb6e169938288442eba05R97-R105

curl request working on Pangeo staging hub:

Screenshot 2021-10-27 at 10 43 46

@sgibson91
Allow singleuser pods to talk to ingress controller
e07c828 
This allows code in hubs to talk to the ingress provider, and hence talk
to the hub via it's public URL

Thanks to @yuvipanda for spotting this and their code from here:
yuvipanda/datahub@e8544b0#diff-c7ff155658f0273e3fd2df49dee1551363b934660d0cb6e169938288442eba05R97-R105
@sgibson91 sgibson91 requested a review from yuvipanda October 27, 2021 09:46
@sgibson91 sgibson91 self-assigned this Oct 27, 2021
@sgibson91 sgibson91 marked this pull request as ready for review October 27, 2021 09:46
@sgibson91 sgibson91 mentioned this pull request Oct 27, 2021
Closed
5 tasks
yuvipanda
yuvipanda approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ty! We also need to make this work in clusters that don't use an ingress controller to get traffic into themselves (but instead use z2jh's built-in autohttps), but that shouldn't block this PR

@sgibson91 sgibson91 merged commit efbb94b into 2i2c-org:master Oct 27, 2021
@sgibson91 sgibson91 deleted the allow-traffic-to-public-url branch October 27, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda approved these changes

Assignees

@sgibson91 sgibson91

Labels
None yet
Projects
No open projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgibson91 @yuvipanda