Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow traffic to autohttps pod from singleuser #788

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Allow traffic to autohttps pod from singleuser #788

merged 1 commit into from
Oct 28, 2021

Conversation

sgibson91
Copy link
Member

Addresses #741

@sgibson91 sgibson91 marked this pull request as ready for review October 28, 2021 12:10
@sgibson91 sgibson91 mentioned this pull request Oct 28, 2021
Closed
5 tasks
yuvipanda
yuvipanda approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tested on a hub that uses the autohttps setup, but LGTM!

@sgibson91
Copy link
Member Author

Tested this on Farallon staging and all good!

Screenshot 2021-10-28 at 14 27 47

@sgibson91 sgibson91 merged commit ab1a2da into 2i2c-org:master Oct 28, 2021
@sgibson91 sgibson91 deleted the allow-egress-autohttps branch October 28, 2021 13:28
@yuvipanda
Copy link
Member

Thanks a lot, @sgibson91! IMO this also deserves a blog post...

@sgibson91
Copy link
Member Author

@yuvipanda I added it to the (long! 😬) list here 2i2c-org/team-compass#244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgibson91 @yuvipanda