Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Issues with pushing JSON file to repo #158

Closed
sgibson91 opened this issue Mar 6, 2023 · 5 comments
Closed

Issues with pushing JSON file to repo #158

sgibson91 opened this issue Mar 6, 2023 · 5 comments
Assignees

Comments

@sgibson91
Copy link
Member

sgibson91 commented Mar 6, 2023

Context

The workflows in this repo push the team-roles.json file to the main branch. These have just recently started failing with a 403 against the github-actions[bot] user, even with branch protection rules turned off. I'm not sure what has changed to cause this failure. It could be an upstream change in the EngBug/add-and-commit action.

Potential courses of action:

  • Monitor EndBug/add-and-commit for issues/updates (this is semi-automated by dependabot, but we use a v9 tag and may need to pin to a specific one for a while as we wait for changes to propagate)
  • We can use actions/checkout to checkout with a PAT, which will then be consumed by EndBug/add-and-commit to do the push. I suspect my handle might not receive a 403 like the bot user does.
  • Do nothing. We are currently reevaluating support processes anyway and the bot/rotational nature of the work is likely to be retired.

Proposal

No response

Updates and actions

No response

@sgibson91
Copy link
Member Author

As an aside, allowing GitHub Actions to push to protected branches is a sought after feature that is apparently not being prioritised by GitHub right now https://github.com/orgs/community/discussions/25305

@damianavila
Copy link

damianavila commented Mar 7, 2023

Do nothing. We are currently reevaluating support processes anyway and the bot/rotational nature of the work is likely to be retired.

I would suggest waiting as well. I noticed something similar in the action for our website: https://github.com/2i2c-org/2i2c-org.github.io/actions/runs/4330406134. Wondering if it is somehow related...

@sgibson91
Copy link
Member Author

@damianavila Ah yes, 2i2c-org/infrastructure#359 will be the cause of that

@sgibson91
Copy link
Member Author

This was fixed by adding permissions in #162, showing that the above issue was the cause

@github-project-automation github-project-automation bot moved this from Needs Shaping / Refinement to Complete in DEPRECATED Engineering and Product Backlog Mar 20, 2023
@damianavila
Copy link

This was fixed by adding permissions in #162, showing that the above issue was the cause

Yep, I did the very same thing in another PR a few days back: 2i2c-org/2i2c-org.github.io#152

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants