Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fetch strategy type #17

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: add fetch strategy type #17

merged 1 commit into from
Nov 8, 2024

Conversation

Marsup
Copy link

@Marsup Marsup commented Nov 8, 2024

@Marsup Marsup requested a review from ducher November 8, 2024 06:38
Copy link
Collaborator

@ducher ducher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok when checking JS code, the constant has the same values, however I got lost when trying to find the code using the options for insertGraph, too much inheritance and abstraction through classes

@ducher ducher merged commit eb6de22 into main Nov 8, 2024
4 checks passed
@ducher ducher deleted the fix/fetch-strategy branch November 8, 2024 16:10
@Marsup Marsup mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants