Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatalError when body is an invalid image #195

Closed
nsoojin opened this issue Feb 3, 2017 · 4 comments
Closed

fatalError when body is an invalid image #195

nsoojin opened this issue Feb 3, 2017 · 4 comments

Comments

@nsoojin
Copy link
Collaborator

nsoojin commented Feb 3, 2017

Hi,
Right now app crashes due to the fatal error in the initializer of ImageResult enum when the response body cannot be casted to Image.
But I think this should not be a fatal error because it is a problem from backend and developers can recover from and handle such cases.
So rather than fatal-erroring, how about make it a failure (parsing error perhaps?).
If you think the same way, I'll make a PR

@3lvis
Copy link
Owner

3lvis commented Feb 3, 2017

Hi @nsoojin,

Is this what you were talking about #196?

I'm gonna add you as a contributor so it's easier for you to contribute :) If you have any suggestions or want to improve anything we can discuss it in Gitter, might make communication easier.

https://gitter.im/SwiftNetworking/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link

@3lvis
Copy link
Owner

3lvis commented Feb 3, 2017

Fixed in #196

@3lvis 3lvis closed this as completed Feb 3, 2017
@nsoojin
Copy link
Collaborator Author

nsoojin commented Feb 3, 2017

wow that was fast!
ok thanks :)
looking forward to contribute!

@3lvis
Copy link
Owner

3lvis commented Feb 3, 2017

@nsoojin yay! 💐

Released in Networking 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants