-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatalError when body is an invalid image #195
Comments
Fixed in #196 |
wow that was fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Right now app crashes due to the fatal error in the initializer of ImageResult enum when the response body cannot be casted to Image.
But I think this should not be a fatal error because it is a problem from backend and developers can recover from and handle such cases.
So rather than fatal-erroring, how about make it a failure (parsing error perhaps?).
If you think the same way, I'll make a PR
The text was updated successfully, but these errors were encountered: