Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS objects support #133

Merged
merged 4 commits into from
May 2, 2023
Merged

CMS objects support #133

merged 4 commits into from
May 2, 2023

Conversation

mkudlej
Copy link
Collaborator

@mkudlej mkudlej commented Mar 24, 2023

  • add support for mixed entity names in one collection
  • add CMS files, sections, pages, layouts, partials
  • add related unit tests

@mkudlej mkudlej changed the title CMS objects support [WIP] CMS objects support Mar 24, 2023
@mkudlej mkudlej marked this pull request as draft March 24, 2023 16:59
pehala
pehala reviewed Mar 27, 2023
View reviewed changes
tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
threescale_api/resources.py Show resolved Hide resolved
tests/integration/test_integration_cms.py Outdated Show resolved Hide resolved
tests/integration/test_integration_cms.py Outdated Show resolved Hide resolved
tests/integration/test_integration_cms.py Outdated Show resolved Hide resolved
threescale_api/resources.py Show resolved Hide resolved
@mkudlej mkudlej force-pushed the cms_api_1 branch 2 times, most recently from b4cf632 to d03e0ac Compare April 4, 2023 13:47
@mkudlej mkudlej requested a review from pehala April 4, 2023 13:49
@mkudlej mkudlej marked this pull request as ready for review April 5, 2023 06:37
@mkudlej mkudlej changed the title [WIP] CMS objects support CMS objects support Apr 5, 2023
@pehala
Copy link
Collaborator

pehala commented Apr 5, 2023 •
edited
Loading

I have no more objections except for commit history, which needs to be fixed

@mkudlej
add support for mixed entity names in one collection
5259051 
add CMS files, sections, pages, layouts, partials
add related unit tests
@mkudlej
add pages
64504be 
change client pager and some lints
@mkudlej
add publishing
b8c47fe
pehala
pehala previously approved these changes Apr 6, 2023
View reviewed changes
jsmolar
jsmolar reviewed Apr 6, 2023
View reviewed changes
threescale_api/utils.py Outdated Show resolved Hide resolved
@mkudlej mkudlej marked this pull request as draft April 14, 2023 11:26
@mkudlej
Copy link
Collaborator Author

mkudlej commented Apr 14, 2023

I've moved into draft state because I need to wait for another build to be able to check this PR again.

@mkudlej mkudlej marked this pull request as ready for review April 28, 2023 10:01
@mkudlej mkudlej requested review from jsmolar and pehala April 28, 2023 10:02
@mkudlej
Copy link
Collaborator Author

mkudlej commented May 2, 2023

I have rewritten _extract_resource method because in this API there is different response structure as in other 3scale APIs.

@mkudlej mkudlej merged commit c7b5dc0 into 3scale-qe:master May 2, 2023
@mkudlej mkudlej deleted the cms_api_1 branch May 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmolar jsmolar jsmolar approved these changes

@pehala pehala pehala approved these changes

@mganisin mganisin Awaiting requested review from mganisin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkudlej @pehala @jsmolar