Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use routerLink for counters section #26

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Apr 28, 2023

WIP: still working on some tests, although the whole component functionality tests are currently skipped.

References

Add references/links to any related issues or PRs. These may include:
Fixes: #19

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • use routerLink instead of link for smoother performance when interacting with the section (no reload)
  • routerLink and additional QueryParams are possible

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

use routerLink for counter section component
@floriangantner floriangantner marked this pull request as ready for review May 9, 2023 10:14
@floriangantner floriangantner changed the title Draft: use routerLink for counters section use routerLink for counters section May 9, 2023
@floriangantner
Copy link
Author

meanwhile superseded by similar commit c1c5a66#diff-fa2b04cc8f2b5b8a618883582c9320466bdc4c36f1f14506164744cefe370f1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

counters component could use internal routing
1 participant