Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Scroll setting is not working properly on Android #23

Closed
M-HARIS-97 opened this issue Dec 15, 2022 · 11 comments
Closed

[Bug] Scroll setting is not working properly on Android #23

M-HARIS-97 opened this issue Dec 15, 2022 · 11 comments
Labels
bug Something isn't working dependencies An issue caused by an upstream dependency Platform: Android

Comments

@M-HARIS-97
Copy link

Please check the following video;

Project.Name.mp4
@jspizziri
Copy link
Contributor

@M-HARIS-97 please create a reproduction in the example app. I haven't seen this before.

@jspizziri jspizziri moved this to 🔁 In Progress in react-native-readium Dec 15, 2022
@M-HARIS-97
Copy link
Author

M-HARIS-97 commented Dec 20, 2022 •
edited
Loading

@jspizziri This epub has overflow-x: hidden / overflow-x: visible CSS for the <body> tag. That is what is causing this.

@jspizziri
Copy link
Contributor

@M-HARIS-97 glad you sorted it out.

@mickael-menu
Copy link

This particular issue should be fixed in the next version of the Kotlin toolkit, see readium/kotlin-toolkit#294

@jspizziri jspizziri added dependencies An issue caused by an upstream dependency and removed unconfirmed labels Dec 20, 2022
@jspizziri
Copy link
Contributor

@mickael-menu , wow! Thanks for letting us know! 🙏

How did this come across your radar in this project?

@mickael-menu
Copy link

I found this wrapper thanks to you actually 😄 I'm subscribed to the activity now.

Feel free to come participate in our bi-weekly Zoom calls or API discussions on Slack and the Readium repos. The more the merrier!

@jspizziri
Copy link
Contributor

@mickael-menu I just might do that! Where can I find the invite links?

@mickael-menu
Copy link

You should receive a Slack invitation by mail soon, let me know if you don't. Our Zoom calls are notified on the #general channel but we're taking a break until end of January to figure out what's the best timing and cast.

@jspizziri
Copy link
Contributor

@M-HARIS-97 kotlin-tooklit 2.3.0 has been released. As mentioned above the fix for this issue is contained in that release.

What remains to be done is to upgrade this library to use that version. Based on the migration guide it looks like there are several changes we'll need to make (specifically to how preferences work) in order to upgrade.

I encourage you to investigate and put together a PR if you need this fix soon. As for our team, it will probably be a while before it falls on our roadmap.

@mickael-menu
Copy link

The changes regarding the Preferences API and the HTTP server are optional in 2.3.0. However the Decoration.extras and PDF support sections in the migration guide are required to upgrade.

@jspizziri jspizziri changed the title Scroll setting is not working properly on Android [Bug] Scroll setting is not working properly on Android Feb 7, 2023
@jspizziri jspizziri mentioned this issue Jun 13, 2023
Open
@jspizziri
Copy link
Contributor

@M-HARIS-97 i've just merged an upgrade to kotlin-toolkit@2.4.1, which should resolve this issue.

@github-project-automation github-project-automation bot moved this from 🔁 In Progress to ✅ Done in react-native-readium Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies An issue caused by an upstream dependency Platform: Android
Projects
react-native-readium
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jspizziri @M-HARIS-97 @mickael-menu