Skip to content

Commit

Permalink
Fix label for pointing to a name instead of id in webhook setti…
Browse files Browse the repository at this point in the history
…ngs (go-gitea#29209)

Here's the spec for the `for` attribute:
https://html.spec.whatwg.org/multipage/forms.html#attr-label-for

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit 0157db8)
  • Loading branch information
yardenshoham authored and earl-warren committed Feb 17, 2024
1 parent a46fa02 commit f9c931d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/repo/settings/webhook/settings.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@
<!-- Branch filter -->
<div class="field">
<label for="branch_filter">{{ctx.Locale.Tr "repo.settings.branch_filter"}}</label>
<input name="branch_filter" type="text" value="{{or .Webhook.BranchFilter "*"}}">
<input id="branch_filter" name="branch_filter" type="text" value="{{or .Webhook.BranchFilter "*"}}">
<span class="help">{{ctx.Locale.Tr "repo.settings.branch_filter_desc" | Str2html}}</span>
</div>

Expand Down

0 comments on commit f9c931d

Please sign in to comment.