From e2ac29e825e356529c5f8200bd39dc3dc968338b Mon Sep 17 00:00:00 2001 From: Ghislain B Date: Tue, 2 May 2023 21:50:30 -0400 Subject: [PATCH] feat(plugins): remove jQuery from ColumnPicker & GridMenu controls (#752) * feat(plugins): remove jQuery from ColumnPicker & GridMenu controls * tests: use input checked property instead of attr checked - the previous code with `attr('checked')` was jQuery oriented and we are going away from jQuery --- controls/slick.columnpicker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controls/slick.columnpicker.js b/controls/slick.columnpicker.js index fe333c9d..a44e6396 100644 --- a/controls/slick.columnpicker.js +++ b/controls/slick.columnpicker.js @@ -301,13 +301,13 @@ col.hidden = false; visibleColumns.splice(idx, 0, col); } else { - let newVisibleColumns = []; + let newVisibleColumns = []; for (let i = 0; i < visibleColumns.length; i++) { if (visibleColumns[i].id !== col.id) { newVisibleColumns.push(visibleColumns[i]); } } visibleColumns = newVisibleColumns; } - + _grid.setColumns(visibleColumns); onColumnsChanged.notify({ columnId: col.id, showing: show, allColumns: columns, columns: visibleColumns, grid: _grid }); }