Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specific reference to 'master' version in mom5 and oasis packages #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atteggiani
Copy link

@atteggiani atteggiani commented Oct 14, 2024

Copy link
Contributor

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine to me, but please ask @harshula to also review. I think that he might want to leave the 'f' strings as-is.

@harshula
Copy link
Collaborator

harshula commented Nov 10, 2024

Hi @atteggiani , Please leave the 'f' strings as-is. I need them to modify the compiler flags more dynamically in the future.

Also, we need the first with when() to work with versions other than master. If you can test @git.development and it still works with your change, then we can consider including this change.

IIRC, @penguian did a lot of meticulous testing to ensure this worked properly. I'd prefer not to make any changes to these conditionals unless there's a good reason.

@harshula harshula self-requested a review November 10, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set dependencies conditions to specific defined versions
3 participants