Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DMC ProMP environments were actually all using DMP. #71

Closed
wants to merge 1 commit into from
Closed

Fix: DMC ProMP environments were actually all using DMP. #71

wants to merge 1 commit into from

Conversation

D-o-d-o-x
Copy link
Collaborator

In fancy_gym/dmc/__init__.py all MP versions of DMP environments are registered to gym. The mp-configs are derived from default configs. All ProMP versions wrongfully derive from the DMP default-config instead of the ProMP default-config.
Since this config also contains the information as to which kind of MP to use, this leads to all ProMP environments using DMPs instead.

import fancy_gym
env = fancy_gym.make('dmc_ball_in_cup-catch_promp-v0', seed=1)
bb = env.env.env
print(bb.traj_gen.__class__)
-> <class 'mp_pytorch.mp.dmp.DMP'>   # should be ProMP, not DMP

@D-o-d-o-x
Copy link
Collaborator Author

The issue was already addressed by PR#75.

@D-o-d-o-x D-o-d-o-x closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant