Jh press schema changes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an array of heaters under press. using Heater-v1 schema
temperature and pressure tags are expanded to arrays
amrc-benmorrow
requested changes
Oct 31, 2024
schema exported from acs manager did not match the original schema. changes have been made to acomodate.
removed tools schema uuid
JSON Validated
removed uuid
amrc-benmorrow
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from populating the press schema with data from the 1m press raised some slight changes to requirements. Press schema now includes an array of heaters to avoid the need for different devices using the same connection. Tool schema now includes arrays of pressure and temperature tags rather than single tags to allow for multiple sensors on a single tool.