Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in define PCL #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions elevation_mapping/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ set(
kindr
kindr_ros
message_filters
filters
pcl_ros
roscpp
sensor_msgs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

namespace pcl {

#ifndef PCL_MAKE_ALIGNED_OPERATOR_NEW
#define PCL_MAKE_ALIGNED_OPERATOR_NEW EIGEN_MAKE_ALIGNED_OPERATOR_NEW
#endif
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
struct _PointXYZRGBConfidenceRatio {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#pragma once

#include <ros/ros.h>
#include <filters/filter_chain.hpp>
#include <filters/filter_chain.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, since we target noetic, this change cannot be accepted.

#include <grid_map_core/GridMap.hpp>

namespace elevation_mapping {
Expand Down Expand Up @@ -88,4 +88,4 @@ class PostprocessingPipelineFunctor {
bool filterChainConfigured_;
};

} // namespace elevation_mapping
} // namespace elevation_mapping
1 change: 1 addition & 0 deletions elevation_mapping/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<depend>kindr</depend>
<depend>kindr_ros</depend>
<depend>message_filters</depend>
<depend>filters</depend>
<depend>pcl_ros</depend>
<depend>roscpp</depend>
<depend>sensor_msgs</depend>
Expand Down