From 2e82708a49ad92c3499a8a60326029f04a5cd65a Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Mon, 11 Dec 2023 14:59:50 +0000 Subject: [PATCH] [buildattr64] More review comments from MaskRay Make further corrections, these were all non-functional in nature. This commit will be squashed prior to merging. --- buildattr64/README.md | 4 +++- buildattr64/buildattr64.rst | 1 - design-documents/buildattr64-rationale.rst | 4 +--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/buildattr64/README.md b/buildattr64/README.md index 49cdb47..31713cf 100644 --- a/buildattr64/README.md +++ b/buildattr64/README.md @@ -6,7 +6,9 @@ ## About this document -The [Build Attributes for the Arm 64-bit Architecture](buildattr64.rst) describes the +The [Build Attributes for the Arm 64-bit Architecture](buildattr64.rst) +describes the implementation of build attributes for the 64-bit +Arm Architecture. ## About the license diff --git a/buildattr64/buildattr64.rst b/buildattr64/buildattr64.rst index 6afb75e..bba2ca4 100644 --- a/buildattr64/buildattr64.rst +++ b/buildattr64/buildattr64.rst @@ -902,4 +902,3 @@ Private subsections ------------------- The tool interface for private subsections is implementation defined. - diff --git a/design-documents/buildattr64-rationale.rst b/design-documents/buildattr64-rationale.rst index b597252..ff0132a 100644 --- a/design-documents/buildattr64-rationale.rst +++ b/design-documents/buildattr64-rationale.rst @@ -292,7 +292,7 @@ attributes can have advantages when modelling properties that: multiple feature bits with forcing functions. A concrete example is ``FEAT_LSE2`` which can only exist if ``FEAT_LSE`` exists. -- require more then one attribute to describe. For example the +- require more than one attribute to describe. For example the (PAUTHABI64_) describes signing schema as a tuple of (vendor, version). This would require two attributes to completely describe. @@ -543,5 +543,3 @@ There are several downsides: - Humans make textual errors, requiring validation and error handling. - Textual formats are slower to parse and take up more space. - -