Skip to content

Conversation

@bogdanm
Copy link
Contributor

@bogdanm bogdanm commented Jan 12, 2016

All the initialization related to console operations (stdout/stderr/stdin)
now happens in retarget.cpp. The relevant parts will be removed from the
target specific code in subsequent commits.

All the initialization related to console operations (stdout/stderr/stdin)
now happens in retarget.cpp. The relevant parts will be removed from the
target specific code in subsequent commits.
@bogdanm
Copy link
Contributor Author

bogdanm commented Jan 12, 2016

Also fixes #132
Tested on FRDM-K64F.

@bogdanm
Copy link
Contributor Author

bogdanm commented Jan 12, 2016

DO NOT MERGE without ARMmbed/mbed-hal-ksdk-mcu#54 and ARMmbed/mbed-hal-st-stm32f4#31

@bogdanm
Copy link
Contributor Author

bogdanm commented Jan 12, 2016

@0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 12, 2016

Should stdio_uart_inited flag be set to 1 once initialized = stdio_uart only initialized once?

+1 I am trying to understand why HAL was setting init flag and copying the structure (I dont think we used that updated structure anywhere).

@bogdanm
Copy link
Contributor Author

bogdanm commented Jan 12, 2016

Should stdio_uart_inited flag be set to 1 once initialized = stdio_uart only initialized once?

Ah, of course, you're right. I'll fix that.

I am trying to understand why HAL was setting init flag and copying the structure (I dont think we used that updated structure anywhere).

I'm trying to understand why we did stdio initialization in the HALs at all. If we had a reason, I don't remember it.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 12, 2016

I added the same changeset to nrf51822: ARMmbed/mbed-hal-nrf51822-mcu#39

@bogdanm
Copy link
Contributor Author

bogdanm commented Jan 12, 2016

Fixed initialization sequence.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 12, 2016

+1

bogdanm added a commit that referenced this pull request Jan 12, 2016
@bogdanm bogdanm merged commit 498bedb into master Jan 12, 2016
@bogdanm bogdanm deleted the fix_default_baudrate branch January 12, 2016 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants