This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Simplify UPD and IPv4/IPv6 selections #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanneKiiskila
force-pushed
the
simplify_udp_v
branch
from
f7cc053 to
7d33576
Compare
Idea is that MESH has to have hard-coded IPv6 server address, because
it does not have DNS capability. Other networks should have.
Also, UDP must be used with MESH - other networks we want to default to
TCP because it is typically more reliable (UDP gets closed due to firewalls).
Thirdly, IPv4/IPv6 selection should now happen automatically through
the mbed_app.json selections with no need to modify the .h-file anymore
by modifying the
"lwip.ipv4-enabled": false,
"lwip.ipv6-enabled": true
selections accordingly.
JanneKiiskila
force-pushed
the
simplify_udp_v
branch
from
7d33576 to
b66fc5d
Compare
|
rebuild |
|
rebuild |
1 similar comment
|
rebuild |
|
Note: we need to include these changes in RC for next round of OOB. |
This was referenced Dec 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that MESH has to have hard-coded IPv6 server address, because
it does not have DNS capability. Other networks should have.
Also, UDP must be used with MESH - other networks we want to default to
TCP because it is typically more reliable (UDP gets closed due to firewalls).
Thirdly, IPv4/IPv6 selection should now happen automatically through
the mbed_app.json selections with no need to modify the .h-file anymore
by modifying the
"lwip.ipv4-enabled": false,
"lwip.ipv6-enabled": true
selections accordingly.