[STM32] remove superfluous calls to SystemCoreClockUpdate

Laurent MEUNIER · Laurent MEUNIER · commit 6ae979fc5fe3 · 2016-08-29T09:39:00.000+02:00
Supported toolchains initialization steps have been modified to make sure
that mbed_sdk_initi is called _after_ RAM initialization and _before_ C++
objects creation.

since this was done, there is no need to redundant SystemCoreClockUpdates
in the drivers
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F0/pwmout_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F0/pwmout_api.c
@@ -162,9 +162,6 @@ void pwmout_period_us(pwmout_t* obj, int us) {
 
     __HAL_TIM_DISABLE(&TimHandle);
 
-    // Update the SystemCoreClock variable
-    SystemCoreClockUpdate();
-
     /* To make it simple, we use to possible prescaler values which lead to:
      * pwm unit = 1us, period/pulse can be from 1us to 65535us
      * or
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F1/pwmout_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F1/pwmout_api.c
@@ -152,9 +152,6 @@ void pwmout_period_us(pwmout_t* obj, int us)
 
     __HAL_TIM_DISABLE(&TimHandle);
 
-    // Update the SystemCoreClock variable
-    SystemCoreClockUpdate();
-
     /* To make it simple, we use to possible prescaler values which lead to:
      * pwm unit = 1us, period/pulse can be from 1us to 65535us
      * or
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F3/i2c_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F3/i2c_api.c
@@ -113,9 +113,6 @@ void i2c_frequency(i2c_t *obj, int hz)
     timeout = LONG_TIMEOUT;
     while ((__HAL_I2C_GET_FLAG(&I2cHandle, I2C_FLAG_BUSY)) && (timeout-- != 0));
 
-    // Update the SystemCoreClock variable.
-    SystemCoreClockUpdate();
-
     /*
        Values calculated with I2C_Timing_Configuration_V1.0.1.xls file (see AN4235)
        * Standard mode (up to 100 kHz)
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F3/pwmout_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F3/pwmout_api.c
@@ -159,9 +159,6 @@ void pwmout_period_us(pwmout_t* obj, int us)
 
     __HAL_TIM_DISABLE(&TimHandle);
 
-    // Update the SystemCoreClock variable
-    SystemCoreClockUpdate();
-
     /* To make it simple, we use to possible prescaler values which lead to:
      * pwm unit = 1us, period/pulse can be from 1us to 65535us
      * or
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F3/serial_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F3/serial_api.c
@@ -82,9 +82,6 @@ static void init_uart(serial_t *obj)
         huart->Init.Mode = UART_MODE_TX_RX;
     }
 
-    /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */
-    /* and before HAL Init. SystemCoreClock init required here */
-    SystemCoreClockUpdate();
 
     if (HAL_UART_Init(huart) != HAL_OK) {
         error("Cannot initialize UART\n");
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F4/serial_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F4/serial_api.c
@@ -84,10 +84,6 @@ static void init_uart(serial_t *obj)
         huart->Init.Mode = UART_MODE_TX_RX;
     }
 
-    /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */
-	  /* and before HAL Init. SystemCoreClock init required here */
-    SystemCoreClockUpdate();
-
     if (HAL_UART_Init(huart) != HAL_OK) {
         error("Cannot initialize UART\n");
     }
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32F7/serial_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32F7/serial_api.c
@@ -67,9 +67,6 @@ static void init_uart(serial_t *obj)
         UartHandle.Init.Mode = UART_MODE_TX_RX;
     }
 
-    // Fix because HAL_RCC_GetHCLKFreq() don't update anymore SystemCoreClock
-    SystemCoreClockUpdate();
-
     if (HAL_UART_Init(&UartHandle) != HAL_OK) {
         error("Cannot initialize UART");
     }
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32L1/pwmout_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32L1/pwmout_api.c
@@ -166,8 +166,6 @@ void pwmout_period_us(pwmout_t* obj, int us)
 
     __HAL_TIM_DISABLE(&TimHandle);
 
-    SystemCoreClockUpdate();
-
     /* To make it simple, we use to possible prescaler values which lead to:
      * pwm unit = 1us, period/pulse can be from 1us to 65535us
      * or
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32L1/serial_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32L1/serial_api.c
@@ -82,10 +82,6 @@ static void init_uart(serial_t *obj)
         huart->Init.Mode = UART_MODE_TX_RX;
     }
 
-    /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */
-    /* and before HAL Init. SystemCoreClock init required here */
-    SystemCoreClockUpdate();
-
     if (HAL_UART_Init(huart) != HAL_OK) {
         error("Cannot initialize UART\n");
     }
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32L4/pwmout_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32L4/pwmout_api.c
@@ -167,8 +167,6 @@ void pwmout_period_us(pwmout_t* obj, int us)
 
     __HAL_TIM_DISABLE(&TimHandle);
 
-    SystemCoreClockUpdate();
-
     /* To make it simple, we use to possible prescaler values which lead to:
      * pwm unit = 1us, period/pulse can be from 1us to 65535us
      * or
diff --git a/hal/targets/hal/TARGET_STM/TARGET_STM32L4/serial_api.c b/hal/targets/hal/TARGET_STM/TARGET_STM32L4/serial_api.c
@@ -82,10 +82,6 @@ static void init_uart(serial_t *obj)
         huart->Init.Mode = UART_MODE_TX_RX;
     }
 
-    /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */
-    /* and before HAL Init. SystemCoreClock init required here */
-    SystemCoreClockUpdate();
-
     if (HAL_UART_Init(huart) != HAL_OK) {
         error("Cannot initialize UART\n");
     }

Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,6 @@ static void init_uart(serial_t *obj)`
`82`	`82`	`huart->Init.Mode = UART_MODE_TX_RX;`
`83`	`83`	`}`
`84`	`84`
`85`		`- /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */`
`86`		`- /* and before HAL Init. SystemCoreClock init required here */`
`87`		`- SystemCoreClockUpdate();`
`88`	`85`
`89`	`86`	`if (HAL_UART_Init(huart) != HAL_OK) {`
`90`	`87`	`error("Cannot initialize UART\n");`
Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,6 @@ static void init_uart(serial_t *obj)`
`84`	`84`	`huart->Init.Mode = UART_MODE_TX_RX;`
`85`	`85`	`}`
`86`	`86`
`87`		`- /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */`
`88`		`- /* and before HAL Init. SystemCoreClock init required here */`
`89`		`- SystemCoreClockUpdate();`
`90`		`-`
`91`	`87`	`if (HAL_UART_Init(huart) != HAL_OK) {`
`92`	`88`	`error("Cannot initialize UART\n");`
`93`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,6 @@ static void init_uart(serial_t *obj)`
`67`	`67`	`UartHandle.Init.Mode = UART_MODE_TX_RX;`
`68`	`68`	`}`
`69`	`69`
`70`		`- // Fix because HAL_RCC_GetHCLKFreq() don't update anymore SystemCoreClock`
`71`		`- SystemCoreClockUpdate();`
`72`		`-`
`73`	`70`	`if (HAL_UART_Init(&UartHandle) != HAL_OK) {`
`74`	`71`	`error("Cannot initialize UART");`
`75`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,6 @@ static void init_uart(serial_t *obj)`
`82`	`82`	`huart->Init.Mode = UART_MODE_TX_RX;`
`83`	`83`	`}`
`84`	`84`
`85`		`- /* uAMR & ARM: Call to UART init is done between reset of pre-initialized variables */`
`86`		`- /* and before HAL Init. SystemCoreClock init required here */`
`87`		`- SystemCoreClockUpdate();`
`88`		`-`
`89`	`85`	`if (HAL_UART_Init(huart) != HAL_OK) {`
`90`	`86`	`error("Cannot initialize UART\n");`
`91`	`87`	`}`