Make StableDiffusionProcessingImg2Img.mask_blur a property, make more inline with PIL GaussianBlur
#12470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes breakage when mask_blur is set after construction. See Coyote-A/ultimate-upscale-for-automatic1111#111 (comment) Thanks to Алексей Трофимов and eunnone for reporting the issue.
This more closely matches the old behavior of PIL's Gaussian blur, and fixes breakage when tiling. See Coyote-A/ultimate-upscale-for-automatic1111#111 (comment) Thanks to Алексей Трофимов and eunnone for reporting the issue.
|
Hi, thanks for opening this PR on my behalf. I was intending to submit myself but hadn't finished writing up a detailed explanation of where the bug was (with example images etc) to make review easier. But yes, this branch fixes the issue for me, and seems to fix it for other people too. |
|
(And yes, it's pretty common on GitHub to submit PR's based on other people's branches. I've done it before, for basically the same reason you did -- being unsure whether the person who owned the branch was going to submit it themself.) |
AUTOMATIC1111
approved these changes
Aug 11, 2023
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't exactly know why GitHub allows me to do this, but I'm opening this PR on @Splendide-Imaginarius's behalf now since it's a pretty intrusive issue.
This fixes an issue where the
mask_blurproperty isn't set in img2img, which has caused problems for Ultimate Upscale and ControlNet, both for a few months now. It was a regression introduced by #10295.Coyote-A/ultimate-upscale-for-automatic1111#111
Mikubill/sd-webui-controlnet#1888
Mikubill/sd-webui-controlnet#1907
Also makes the sigma values match closer to the old behavior of using PIL's
GaussianBlurto reduce seams.Checklist: