Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow EntityLists without ColumnGroup selection and only fixed columns #559

Closed
sleidig opened this issue Dec 14, 2020 · 2 comments
Closed

Allow EntityLists without ColumnGroup selection and only fixed columns #559

sleidig opened this issue Dec 14, 2020 · 2 comments
Assignees
@TheSlimvReal
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user
Milestone
User-Configurable...

Comments

@sleidig
Copy link
Member

sleidig commented Dec 14, 2020

Currently, the generic EntityListComponent requires to set a columnGroup config in the config-fix.json and always displays a toggle button group to select different column groups. For more simple use cases I want to display the list with just a fixed set of columns and not show any selection to the user.

Suggestion:

make the columnGroup object in the config completely optional. If it doesn't exist, just display all defined columns and hide the column group selection UI.
@sleidig sleidig added Priority: High Type: Improvement Improvement/Extension of existing feature with benefit for the user labels Dec 14, 2020
@TheSlimvReal
Copy link
Collaborator

I would not consider this very high priority. The column selection is not visible if only one column group is defined and the creation of a column group does not cost much time.

@TheSlimvReal TheSlimvReal self-assigned this Feb 5, 2021
@TheSlimvReal TheSlimvReal mentioned this issue Feb 5, 2021
Merged
@sleidig sleidig closed this as completed in a917234 Feb 5, 2021
aam-digital-ci pushed a commit that referenced this issue Feb 5, 2021
@semantic-release-bot
chore(release): 2.30.0 [skip ci]
02dbfe4 
# [2.30.0](2.29.0...2.30.0) (2021-02-05)

### Features

* **core:** ColumnGroups and Filters are optional in config ([#635](#635)) ([a917234](a917234)), closes [#559](#559)
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sleidig pushed a commit that referenced this issue Feb 5, 2021
@TheSlimvReal @sleidig
feat(core): ColumnGroups and Filters are optional in config (#635)
7c137cf 
closes  #559
sleidig pushed a commit that referenced this issue Feb 5, 2021
@semantic-release-bot @sleidig
chore(release): 2.30.0 [skip ci]
549e2c7 
# [2.30.0](2.29.0...2.30.0) (2021-02-05)

### Features

* **core:** ColumnGroups and Filters are optional in config ([#635](#635)) ([a917234](a917234)), closes [#559](#559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheSlimvReal TheSlimvReal

Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
None yet
Milestone
User-Configurable UI and Models
Development

No branches or pull requests
3 participants
@sleidig @TheSlimvReal @aam-digital-ci